Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(secretsmanager): add new check secretsmanager_secret_unused #5428

Merged
merged 8 commits into from
Oct 17, 2024
Merged

feat(secretsmanager): add new check secretsmanager_secret_unused #5428

merged 8 commits into from
Oct 17, 2024

Conversation

puchy22
Copy link
Member

@puchy22 puchy22 commented Oct 16, 2024

Context

Check if secrets have been used recently.

Description

  • Add last_accessed to Secret model
  • Test new projects attribute
  • Add configurable attribute
  • Add check logic
  • Add unit testing for the check

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested review from a team as code owners October 16, 2024 11:06
@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

@github-actions github-actions bot added documentation provider/aws Issues/PRs related with the AWS provider labels Oct 16, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.37%. Comparing base (45c32ab) to head (0c05dd5).
Report is 20 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5428      +/-   ##
==========================================
+ Coverage   89.21%   89.37%   +0.16%     
==========================================
  Files        1044     1050       +6     
  Lines       32225    32598     +373     
==========================================
+ Hits        28750    29135     +385     
+ Misses       3475     3463      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sergargar
sergargar requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, review my comments.

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

@sergargar sergargar self-requested a review October 17, 2024 13:43
@sergargar sergargar merged commit a17cf1b into master Oct 17, 2024
12 checks passed
@sergargar sergargar deleted the PRWLR-4481-remove-unused-secrets-manager-secrets branch October 17, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergargar sergargar sergargar approved these changes

Assignees
No one assigned
Labels
documentation provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puchy22 @sergargar